Skip to content

feat(import): add script tool for multiple hbase snapshot imports)#4606

Open
tianlei2 wants to merge 9 commits intogoogleapis:mainfrom
tianlei2:add-snapshot-import-script
Open

feat(import): add script tool for multiple hbase snapshot imports)#4606
tianlei2 wants to merge 9 commits intogoogleapis:mainfrom
tianlei2:add-snapshot-import-script

Conversation

@tianlei2
Copy link
Copy Markdown

@tianlei2 tianlei2 commented Apr 30, 2026

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

b/429250716

This is the second PR with the shell tool script. This a child of #4600, so the only file that needs to be reviewed is the script itself (bigtable-dataflow-parent/bigtable-beam-import/run-snapshot-import.sh). If this looks ok, I will merge this with the parent PR.

The script is originally from https://docs.google.com/document/d/1T7BQF-AYY8xGbdbhwkV7zPA11A_Fh5SRjA_7nkzeTos/edit?tab=t.twzz7rrh6jz7#heading=h.m7p3xy7m76u2

@tianlei2 tianlei2 requested a review from a team as a code owner April 30, 2026 17:44
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/java-bigtable-hbase API. labels Apr 30, 2026
@tianlei2 tianlei2 changed the title feat(add script tool for multiple hbase snapshot imports) feat(import): add script tool for multiple hbase snapshot imports) Apr 30, 2026
@tianlei2 tianlei2 self-assigned this Apr 30, 2026
@tianlei2 tianlei2 requested a review from vermas2012 April 30, 2026 17:47
@tianlei2 tianlei2 force-pushed the add-snapshot-import-script branch 6 times, most recently from 66573db to 3086725 Compare April 30, 2026 18:13
@tianlei2 tianlei2 force-pushed the add-snapshot-import-script branch from 3086725 to 958c187 Compare April 30, 2026 18:16
@tianlei2 tianlei2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2026
@tianlei2 tianlei2 force-pushed the add-snapshot-import-script branch 4 times, most recently from f249f27 to 40e4a02 Compare May 6, 2026 16:23
@tianlei2 tianlei2 force-pushed the add-snapshot-import-script branch from 40e4a02 to af3976d Compare May 6, 2026 16:46
END_SHARD=$2

# Configurations (Uses environment variables if set, otherwise defaults)
export PROJECT_ID="${PROJECT_ID:-google.com:cloud-bigtable-dev}"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't have defaults here.

export BUCKET="${BUCKET:-tianlei-beam-test-bucket}"
export REGION="${REGION:-us-central1}"

export TABLE_NAME="${TABLE_NAME:-validation_test}"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the doc that shows what are available env variables and what is expected to be set there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable-hbase API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants